Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hmac: Missing CHANGELOG entry for NewMac::new_from_slice #77

Closed
str4d opened this issue May 1, 2021 · 4 comments
Closed

hmac: Missing CHANGELOG entry for NewMac::new_from_slice #77

str4d opened this issue May 1, 2021 · 4 comments

Comments

@str4d
Copy link

str4d commented May 1, 2021

It looks like hmac::NewMac::new_varkey was renamed to hmac::NewMac::new_from_slice in 0.11.
@tarcieri
Copy link
Member

tarcieri commented May 1, 2021 •
edited

I suppose we could add a summary of what changed upstream in the crypto-mac crate to each of the MAC crates

@str4d
Copy link
Author

str4d commented May 1, 2021

Oh, then move this issue there, because it's not documented there either.

@str4d
Copy link
Author

str4d commented May 1, 2021

Aha, I see: it was changed for both cipher and crypto-mac (RustCrypto/traits#442), but only documented in the changelog for cipher.

@str4d
Copy link
Author

str4d commented May 1, 2021

Opened RustCrypto/traits#626.

@str4d str4d closed this as completed May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarcieri @str4d