Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgm: decrypt only after tag verification #356

Merged
merged 4 commits into from Aug 24, 2021
Merged

mgm: decrypt only after tag verification #356

merged 4 commits into from Aug 24, 2021

Conversation

newpavlov
Copy link
Member

It results in two-pass decryption which may be a bit less performant than the current approach, but should be a bit more secure in some contexts.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #356 (991a3df) into master (5983bc0) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
+ Coverage   89.19%   89.24%   +0.05%     
==========================================
  Files          39       39              
  Lines        1897     1888       -9     
==========================================
- Hits         1692     1685       -7     
+ Misses        205      203       -2     
Impacted Files Coverage Δ
mgm/src/lib.rs 100.00% <100.00%> (+1.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5983bc0...991a3df. Read the comment docs.

@newpavlov newpavlov merged commit 5709f1b into master Aug 24, 2021
@newpavlov newpavlov deleted the mgm_decrypt branch August 24, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants