Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Improve performance of append and prepend #67

Open
jeswr opened this issue Apr 14, 2022 · 1 comment
Open

Performance: Improve performance of append and prepend #67

jeswr opened this issue Apr 14, 2022 · 1 comment

Comments

@jeswr
Copy link
Collaborator

jeswr commented Apr 14, 2022

See use case for append in #66 .

append and prepend still go through the SimpleTransformIterator

IMO the cleanest way to do this would be to add a parameter to the UnionIterator in #65 that requires the iterators in the union to be consumed sequentially, and then for append and prepend to just return a union of the current source, and the data to append/prepend.

@jacoscaz - do you have any thoughts on this?

@jeswr jeswr changed the title Performance: Imrove performance of append and prepend Performance: Improve performance of append and prepend Apr 14, 2022
@jacoscaz
Copy link
Collaborator

IMHO this is a (very) good idea, although I'm unsure as to how complex the final solution might be. Could be worth having a SequentialUnion iterator if having everything in one class becomes too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants