Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing autoStart, or at least disabling it by default #25

Open
RubenVerborgh opened this issue Sep 25, 2020 · 7 comments · May be fixed by #45
Open

Consider removing autoStart, or at least disabling it by default #25

RubenVerborgh opened this issue Sep 25, 2020 · 7 comments · May be fixed by #45

Comments

@RubenVerborgh
Copy link
Owner

No description provided.

@rubensworks
Copy link
Collaborator

Related to this. If we invoke transform on an iterator with autoStart set to false, should this new iterator inherit autoStart: false?
(This seems to be not the case at the moment)

rubensworks referenced this issue in comunica/comunica Mar 1, 2021
This could occur when the query has 2 or more triple patterns.

Closes #777
@jeswr
Copy link
Collaborator

jeswr commented Feb 14, 2022

As I mentioned in comunica/comunica#907 - it may be useful have this change made prior to the v2 release of Comunica. @rubensworks you noted that "making this change in AsyncIterator might not be trivial." - what kind of problems are you envisioning?

@rubensworks
Copy link
Collaborator

what kind of problems are you envisioning?

Not sure. I just remember spending a lot of time debugging things related to autoStart :-)
But if everything related to autoStart: false works properly now, then it should just be a matter of flipping the default value.

@RubenVerborgh might also have some thoughts about this.

@RubenVerborgh
Copy link
Owner Author

I'm happy to have this change—is there still time? Can release as a v4.0.0-beta first.
It might be quite some precision work though in the tests etc.

@rubensworks
Copy link
Collaborator

Also wondering about time. I hope to enter beta testing for Comunica 2.x later this week.

@jeswr
Copy link
Collaborator

jeswr commented Feb 14, 2022

If we release the beta of asynciterator today I can spend tommorow seeing trying to upgrade comunica - if it's too hard/time consuming then we can just leave it out?

@rubensworks
Copy link
Collaborator

If we release the beta of asynciterator today I can spend tommorow seeing trying to upgrade comunica - if it's too hard/time consuming then we can just leave it out?

Sounds good to me, if you think it's feasible to flip the default value of autoStart here in such a short time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants