Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Tokens): Export individual tokens #3803

Merged
merged 1 commit into from
May 17, 2024
Merged

chore(Tokens): Export individual tokens #3803

merged 1 commit into from
May 17, 2024

Conversation

markhigham
Copy link
Collaborator

Related issue

Closes #3797

Overview

Export individual token members from design-tokens

Link to preview

Usage before

import { selectors } from '@royalnavy/design-tokens'

const { color } = selectors

Usage after

import { color } from '@royalnavy/design-tokens'

Work carried out

  • Destructured and exported individual tokens
  • Update to tokens stories using the new syntax

@markhigham markhigham requested a review from m7kvqbe1 as a code owner May 17, 2024 09:30
@netlify Netlify
Copy link

netlify bot commented May 17, 2024 •
edited

✅ Deploy Preview for storybook-navy-digital-mod-uk ready!

Name Link
🔨 Latest commit 781ac09
🔍 Latest deploy log https://app.netlify.com/sites/storybook-navy-digital-mod-uk/deploys/6647248999a4f00008576dba
😎 Deploy Preview https://deploy-preview-3803--storybook-navy-digital-mod-uk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

m7kvqbe1
m7kvqbe1 approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@m7kvqbe1 m7kvqbe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markhigham markhigham merged commit 1a8b129 into master May 17, 2024
23 checks passed
@markhigham markhigham deleted the chore/expose-tokens branch May 17, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m7kvqbe1 m7kvqbe1 m7kvqbe1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export selector functions directly in @royalnavy/design-tokens
2 participants
@markhigham @m7kvqbe1