Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Tasks #232

Closed
14 of 18 tasks
RohanNagar opened this issue Jul 31, 2018 · 3 comments
Closed
14 of 18 tasks

Cleanup Tasks #232

RohanNagar opened this issue Jul 31, 2018 · 3 comments
Labels
P2 Medium priority. Can be addressed within the next few releases. Size: Medium The work involved in addressing this issue is a sizable amount. 1-2 days of work. Status: Available Work on this issue has not yet started and is available to be worked on. Type: Code Quality Relates to code quality such as comments, style, and best practices.
Milestone
v3.0.0

Comments

@RohanNagar
Copy link
Owner

RohanNagar commented Jul 31, 2018 •
edited

Description
@RohanNagar RohanNagar added Type: Code Quality Relates to code quality such as comments, style, and best practices. P3 Low priority. No set deadline to address. Status: Available Work on this issue has not yet started and is available to be worked on. Size: Medium The work involved in addressing this issue is a sizable amount. 1-2 days of work. labels Jul 31, 2018
@RohanNagar RohanNagar added this to the v2.1.0 milestone Jul 31, 2018
@RohanNagar RohanNagar added P2 Medium priority. Can be addressed within the next few releases. and removed P3 Low priority. No set deadline to address. labels Aug 31, 2018
@RohanNagar RohanNagar mentioned this issue Oct 16, 2018
Merged
3 tasks
@RohanNagar RohanNagar mentioned this issue Jan 25, 2019
Closed
@RohanNagar
Copy link
Owner Author

Moving this to v2.2 as it is not needed to block v2.1

@RohanNagar RohanNagar modified the milestones: v2.1.0, v2.2.0 Jan 25, 2019
@RohanNagar RohanNagar changed the title Clean up maintainability issues Cleanup Tasks Feb 15, 2019
@RohanNagar
Copy link
Owner Author

RohanNagar commented Nov 4, 2019 •
edited 

name: Java CI

on: [push]

jobs:
  lint:
    runs-on: ubuntu-latest
    
    steps:
    - uses: actions/checkout@v1
    - name: Install npm packages
      run: npm --prefix scripts/ install
    - name: Lint Node.js code
      run: npm --prefix scripts/ run lint
    - name: Shellcheck
      run: shellcheck scripts/**/*.sh
    
  build:
    runs-on: ubuntu-latest
    
    env:
      # Dummy keys to use the AWS SDK
      AWS_ACCESS_KEY_ID: 1234567890
      AWS_SECRET_ACCESS_KEY: 1234567890

    steps:
    - uses: actions/checkout@v1
    - name: Set up JDK 1.8
      uses: actions/setup-java@v1
      with:
        java-version: 1.8

    - name: Install npm packages
      run: npm --prefix scripts/ install

    - name: Build with Maven
      run: mvn package jacoco:report

    - name: Run itegration tests
      run: sh -c scripts/tools/integration-tests.sh

    - name: Docker compose integration test
      run: ./scripts/ci/docker-integration-tests.sh general

https://help.github.com/en/actions/configuring-and-managing-workflows/persisting-workflow-data-using-artifacts

@RohanNagar
Copy link
Owner Author

Investigate: https://pitest.org

@RohanNagar RohanNagar modified the milestones: v2.2.0, v3.0.0 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Medium priority. Can be addressed within the next few releases. Size: Medium The work involved in addressing this issue is a sizable amount. 1-2 days of work. Status: Available Work on this issue has not yet started and is available to be worked on. Type: Code Quality Relates to code quality such as comments, style, and best practices.
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@RohanNagar