Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 releases #660

Open
MatthijsBurgh opened this issue Dec 19, 2023 · 10 comments
Open

V2 releases #660

MatthijsBurgh opened this issue Dec 19, 2023 · 10 comments
Assignees
Labels
Discussion v2 Issues and PRs, which will be fixed in v2, as it is a breaking change

Comments

@MatthijsBurgh
Copy link
Contributor

Release procedure

  • Provide build files? Attached to the release?

ToDo before first release

ToDo along the way

@MatthijsBurgh MatthijsBurgh added Discussion v2 Issues and PRs, which will be fixed in v2, as it is a breaking change labels Dec 19, 2023
@blackhorsewu
Copy link

Are the roslibjs and ros3djs workable and usable at the moment? Or which version, v1 or v2, should I use, that is if any one of them is usable?

@EzraBrooks
Copy link
Contributor

The roslibjs release on NPM still works. We're working on releasing 2.0, which will include new features. I'm not sure about ros3djs.

@blackhorsewu
Copy link

blackhorsewu commented Jan 19, 2024 via email

@blackhorsewu
Copy link

I have tried npm install roslibjs, and it reported that "No valid versions available for roslibjs". Then I tried npm install roslib, it warned me "no such file or directory, open '/home/victor/flask_apps/package.json". I ignored it and run the urdf.html example. Then flask reported "GET /build/roslib.js HTTP/1.1" 404 -. So, where can I find /build/roslib.js and where should I put it?

@blackhorsewu
Copy link

@EzraBrooks Thank you for your help and the examples. I have tried your "urdf.html". There I used <script src="https://cdn.jsdelivr.net/npm/roslib@1/build/roslib.js"></script> to get the "roslib.js" and now the web page is working and showed "Connected" in Green.
My next question is how do I display the urdf model on the web page? I have seen there is also a "urdf.html" example in ros3djs. However, I do not know how to feed the urdfModel of your "urdf.html" from my ROS into the ROS3D.UrdfClient. Hopefully the "urdf.html" example of ros3djs can visualize my urdf model. Thank you for your help.

@EzraBrooks
Copy link
Contributor

@MatthijsBurgh Do you think we're good to go to release 2.0 now? I've been using recent builds of the library on my project for quite awhile now and it seems very stable.

I think that instead of attaching build outputs to the release on GitHub we can probably just point users to the UMD version of the build output via unpkg so we don't have to duplicate effort between publishing to NPM and publishing a CDN build.

@EzraBrooks
Copy link
Contributor

@blackhorsewu Sorry I missed your comment here. I actually don't have much experience with ros3djs. I personally use https://github.com/gkjohnson/urdf-loaders. However, you're welcome to open a Discussion if you're still looking for advice.

@MatthijsBurgh
Copy link
Contributor Author

I think we should first make sure we run some ROS2 tests in CI, before releasing a v2

@EzraBrooks
Copy link
Contributor

that makes sense. we use ros2 on my project so it definitely works!

@tall1
Copy link

tall1 commented Mar 26, 2024

that makes sense. we use ros2 on my project so it definitely works!

Can you please provide a guide on how to run roslibjs on ros2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion v2 Issues and PRs, which will be fixed in v2, as it is a breaking change
Projects
None yet
Development

No branches or pull requests

5 participants