Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rosbridge Fragmentation #557

Open
nathanmargaglio opened this issue Aug 1, 2022 · 2 comments
Open

Support rosbridge Fragmentation #557

nathanmargaglio opened this issue Aug 1, 2022 · 2 comments

Comments

@nathanmargaglio
Copy link

The rosbridge protocol provides the ability to fragment messages. This feature doesn't appear to be present in roslibjs.

Is there any plans to implement this? If not, is there some direction that can be provided in terms of getting this implemented?

For full context, I'm interested in using fragmentation in Foxglove, but they explained that they use roslibjs to handle this so such an update would have to occur here.

@MatthijsBurgh
Copy link
Contributor

I am open to supporting this feature.

Though I do not have the time to implement this. So when you want to implement this, I am willing to assist where I can. But the bulk should be done by you (or someone else).

@Rayman
Copy link
Contributor

Rayman commented Aug 22, 2022

Probably adding code to

onmessage: function onMessage(data) {
to store fragments and assemble them, and recalling onmessage with the full message.

Make sure it works with and without compression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants