Ros logging #508
Ros logging #508
Conversation
|
The logging is all in an example. Would be best to make this part of the library IMO. |
Bumps [rollup](https://github.com/rollup/rollup) from 2.67.3 to 2.68.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.67.3...v2.68.0) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MatthijsBurgh
force-pushed
the
ros_logging
branch
from
e9d21a5
to
54235a2
Compare
|
@sea-bass @EzraBrooks What do you think of this PR? |
I would probably prefer to have this be part of the protocol and have the Python backend do actual logging calls through I say this because publishing to |
|
Agreed. I think the "most correct" way to implement this with my knowledge of ROS logging would be to create a protocol-level API in rosbridge + roslib that allows creating namespaced child loggers in the Python backend and then forwarding log content to those from a roslibjs log call. There are some issues with that approach, as we've seen in moveit2, but we're working on fixing them in ROS itself. |
|
I agree with the vision of @sea-bass @EzraBrooks therefore I am closing this PR. |
Public API Changes
Implements Javascript logging functionality similar to ROS logging functions
logwarn,logerr, etc.Description
Created a JS file implementing functions which log to the console and publish to
rosoutbased on the ROS logging level. Created an example file to demonstrate how the functions are used.Resolves #352