Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InsertMode toggle not functioning #2565

Closed
ganjea opened this issue Nov 16, 2021 · 2 comments
Closed

InsertMode toggle not functioning #2565

ganjea opened this issue Nov 16, 2021 · 2 comments
Labels

Comments

@ganjea
Copy link

ganjea commented Nov 16, 2021

Hey there,
during testing I've noticed that the insertMode toggle does not function.

Configuring "insertMode: true/false" works as expected, however during typing switching between those modes via the insert key (https://github.com/RobinHerbots/Inputmask#insertmode) is not toggling the mode. Tested with different Browsers on Windows 10.

A look through the open and closed issues did not yield any information. Additionally, a glance at the source code yields commented out code (

// } else if (k === keyCode.INSERT && !(e.shiftKey || e.ctrlKey) && inputmask.userOptions.insertMode === undefined) { //insert
).

The change seems to be have made with the commit c02deef.

Could you please clarify the status on the insertMode toggle?

@RobinHerbots
Copy link
Owner

@ganjea ,

I don't know why I commented the functionality. I enabled it again and made some minor enhancement.

@ganjea
Copy link
Author

ganjea commented Dec 21, 2021

Thank you for the honesty, quick response and fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants