Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(readme): automatically update example pre-commit version #104

Merged
merged 3 commits into from Oct 26, 2022
Merged

feat(readme): automatically update example pre-commit version #104

merged 3 commits into from Oct 26, 2022

Conversation

demberto
Copy link
Contributor

@demberto demberto commented Sep 9, 2022

No description provided.

@glumia
Copy link

glumia commented Oct 20, 2022

@RobertCraigie please consider prioritizing this one, it's a little change that may save some headaches to people.

Right now when one follows the readme to configure pyright with pre-commit the following error occurs:

An error has occurred: InvalidManifestError:
=====> /Users/gius/.cache/pre-commit/repo0hi7c8c9/.pre-commit-hooks.yaml is not a file
Check the log at /Users/gius/.cache/pre-commit/pre-commit.log

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 68.73% // Head: 68.57% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (5584a03) compared to base (ff13b8a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   68.73%   68.57%   -0.17%     
==========================================
  Files          14       14              
  Lines         595      595              
==========================================
- Hits          409      408       -1     
- Misses        186      187       +1     
Impacted Files Coverage Δ
pyright/cli.py 83.33% <0.00%> (-2.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RobertCraigie RobertCraigie changed the title update: README.md to reflect the latest version feat(readme): automatically update example pre-commit version Oct 26, 2022
@RobertCraigie RobertCraigie merged commit e7a11f0 into RobertCraigie:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants