Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed detection of interface circular reference #1269

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Oct 2, 2022

Fixes #1267

@kukulich kukulich added the bug label Oct 2, 2022
@kukulich kukulich added this to the 6.0.1 milestone Oct 2, 2022
@kukulich kukulich force-pushed the circular-interface branch from 9713283 to 38b5af9 Compare October 2, 2022 10:38
@herndlm
Copy link
Contributor

herndlm commented Oct 2, 2022

Thank you @kukulich
I see you also fixed what I did in #1265 too. Was that part of the problem as well?

@kukulich
Copy link
Collaborator Author

kukulich commented Oct 2, 2022

@herndlm I was not able to solve it without your Stringable fix. I've just force pushed your PR with the mutant fix. I hope it will make your build green and I'll rebase then.

@herndlm
Copy link
Contributor

herndlm commented Oct 2, 2022

I see, thx. Yeah, no worries about my PR, I was just curious :)

@kukulich kukulich force-pushed the circular-interface branch from 38b5af9 to cb9cdf3 Compare October 4, 2022 07:29
@kukulich kukulich changed the base branch from 6.0.x to 6.1.x October 4, 2022 07:29
@kukulich kukulich modified the milestones: 6.0.1, 6.1.0 Oct 4, 2022

Verified

This commit was signed with the committer’s verified signature.
kukulich Jaroslav Hanslík
@kukulich kukulich force-pushed the circular-interface branch from cb9cdf3 to b941631 Compare October 4, 2022 07:40
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kukulich kukulich marked this pull request as ready for review October 4, 2022 07:56
@kukulich kukulich self-assigned this Oct 4, 2022
@kukulich kukulich merged commit 877efaf into Roave:6.1.x Oct 4, 2022
@kukulich kukulich deleted the circular-interface branch October 4, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not-circular interface detected as circular
3 participants