Trimming the run containers so that they use less memory and are safer. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fanyang01 Would you review my PR? |
|
We seem to be doing a lot of memory size tests that are unnecessary. |
|
These alloc. tests were pretty bad because they were platform dependent. |
fanyang01
suggested changes
Apr 15, 2021
| @@ -366,81 +366,6 @@ func TestRleRunReverseIterator16(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestRleRunSearch16(t *testing.T) { | |||
There was a problem hiding this comment.
This test case should not be deleted.
There was a problem hiding this comment.
It relies on the old API. The function it tests has been deleted.
There was a problem hiding this comment.
The test is described as '"RunContainer16.search should respect the prior bounds we provide for efficiency of searching through a subset of the intervals"'. We do not provide this functionality anymore, and it was never used in the actual engine.
|
@fanyang01 Thanks for the read-over. I will merge. We can add more tests later if we'd like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runContainer16.myOpts is subject to data races as indicated in PR #299
It seems like this is an unnecessary component of the code that is better entirely removed. It is what the current PR does.