Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stylelint for scss files #587

Closed
2 tasks
zhyd1997 opened this issue Mar 11, 2022 · 13 comments
Closed
2 tasks

add stylelint for scss files #587

zhyd1997 opened this issue Mar 11, 2022 · 13 comments
Labels
help wanted Extra attention is needed

Comments

@zhyd1997
Copy link
Contributor

zhyd1997 commented Mar 11, 2022

Solution:

https://stylelint.io/user-guide/get-started/#linting-everything-else
stylelint-scss/stylelint-config-standard-scss#5 (comment)
solution

stylelint config

Criteria:

  • 1. Fix all of the issues reported by stylelint,

stylelint check with scss file

  • 2. and add a pre-commit hook calls npx stylelint "**/*.scss".

Note: this blocks the Nextjs migration because of some strange syntax in our .scss file.

@zhyd1997
Copy link
Contributor Author

Some strategies to prevent UI break.

  1. split the issue into smaller tasks(the same to bounty) and assign them to two or more contributors.
  2. assign to one contributor but every commit must be tested by QA.

@um1ng
Copy link

um1ng commented Mar 14, 2022

@mikeghen Hi mike, I have found a lot of stylelint format problems, and I have made a lot of file modifications, such as those shown in the img, but the project cannot run. I think the difficulty of this problem is very high, so I want to ask this question, how much bounty can i get?
SCR-20220314-ryh
unknown

@elvijsTDL
Copy link
Collaborator

@um1ng Changing stuff to kebab-case and adding spaces doesn't seem like a very hard problem , can't most of these automatically be handled with a simple command?

@zhyd1997
Copy link
Contributor Author

Codemod needs some knowledge of AST, but not everyone knows that, including me.

I think the style lint affects many .scss files, we need to confirm that changes do not break the UI.

@mikeghen
Copy link
Contributor

I'm all for formatting so let me know when something's ready here

@um1ng
Copy link

um1ng commented Mar 22, 2022

I'm all for formatting so let me know when something's ready here

Yeah, I am ready do these tasks.

@zhyd1997
Copy link
Contributor Author

@um1ng
I am confirming that if you still working on it, if no, this will be picked by other devs.

If yes, you can submit a PR, and @mikeghen will put a bounty then, like this issue: #584 (comment) (Task was finished and Mike put $1000 bounty on it, for example)

@um1ng
Copy link

um1ng commented Mar 24, 2022

@um1ng I am confirming that if you still working on it, if no, this will be picked by other devs.

If yes, you can submit a PR, and @mikeghen will put a bounty then, like this issue: #584 (comment) (Task was finished and Mike put $1000 bounty on it, for example)

Okay, I'll do it as soon as possible.

@mikeghen
Copy link
Contributor

@um1ng @zhyd1997, is this done? I'm adding a $250 bounty to it

@mikeghen mikeghen added help wanted Extra attention is needed $250 bounty labels Apr 28, 2022
@Himnashu
Copy link
Contributor

@mikeghen If no one is doing this, I can pick it up this weekend.

@mikeghen
Copy link
Contributor

@Himnashu, go ahead, lmk how it goes

@Seroxdesign
Copy link
Contributor

@Himnashu

Any progrss on this?

@mindsgn
Copy link
Collaborator

mindsgn commented Aug 18, 2022

@Seroxdesign take this on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants