Full JsonException type name in DateFormatConverter #1505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was using this to generate C# definitions for the Transifex v3 API (using the JSON from their Download OpenAPI specification link, the generated code was not building because the type
JsonException
could not be found in the case that it appears within theDateFormatConverter
(when SystemTextJson is used).I changed it to use the full type name (
System.Text.Json.JsonException
), as seems to be the common use pattern elsewhere, and that seems to have fixed it.In case it's useful, the settings that I was using were:
(Note: There is still an error generating code for the Transifex API when the content type
application/vnd.api+json;profile="bulk"
is specified because the quotes don't get escaped - but I've raised that as a separate issue)