Update JsonInheritanceConverter.liquid

[zyofeng]

The JsonInheritanceConverters need to be made public so downstream NSwag Generator can get the DiscriminatorName (i.e. wrapping Client classes in another generated client class)

Error below:
6> ---> Microsoft.CSharp.RuntimeBinder.RuntimeBinderException: 'System.Text.Json.Serialization.JsonConverter' does not contain a definition for 'DiscriminatorName'

[RicoSuter]

The JsonInheritanceConverters need to be made public so downstream NSwag Generator can get the DiscriminatorName (i.e. wrapping Client classes in another generated client class)

I dont think that it needs to be public (as in reflection internal is the same as public I think)
Did you try the latest NSwag/NJS version as I think this has already been fixed.

[zyofeng]

I'm using the latest NSwag.msbuild which is still affected. After manually modifying the accessor to public the problem went away.

[zyofeng]

The JsonInheritanceConverters need to be made public so downstream NSwag Generator can get the DiscriminatorName (i.e. wrapping Client classes in another generated client class)

I dont think that it needs to be public (as in reflection internal is the same as public I think) Did you try the latest NSwag/NJS version as I think this has already been fixed.

I have created a repo replicating the problem using latest NSwag.AspNetCore as well as NSwag.Build.
https://github.com/zyofeng/NswagGenerationIssue

I think the issue is when client codes are from different projects, NJsonSchema.OpenApiDiscriminator.AddMapping is unable to get the method through reflection due to JsonInheritanceConverter being an internal class from a different project

[zyofeng]

Alternatively we can use InternalsVisibleTo("NJsonSchema")
But this will make the entire assembly visible to NJsonSchema, which seems a bit excessive.

[zyofeng]

Also updated DateFormatConverter.liquid due to missing namespace.

[RicoSuter]

Can you also fix the tests?

[zyofeng]

Done.