Slow sync with --download-missing --use-photokit option #1504
Comments
|
Are you using |
|
Yes, I do. |
|
If you use |
|
Please try running this command and post the output: edited to add osxphotos --profile \
--watch osxphotos.photoexporter::PhotoExporter._stage_missing_photos_for_export \
--watch osxphotos.photoexporter::PhotoExporter._stage_photo_for_export_with_photokit \
--watch osxphotos.photoexporter::PhotoExporter._should_update_photo \
export /private/tmp \
--directory "{created.year}/{created.year}-{created.mm}-{created.dd}" \
--retry 3 --sidecar XMP \
--keyword-template "{label}" \
--keyword-template "{keyword}" \
--keyword-template "{person}" \
--keyword-template "{album}" \
--replace-keywords \
--sidecar-drop-ext \
--edited-suffix "_edited" --update --cleanup \
--report /tmp/export_{today.date}.csv \
--download-missing --use-photokit \
--verbose \
--limit 10 > osxphotos_profile.txtThis uses some of the built-in debugging features of osxphotos to watch certain function calls. It sounds like the photokit is getting called even when not needed but looking at the code, I don't see why. Send the |
|
After completing the full remaining downloads it seems to be a lot faster. Not as fast as without |
|
At the end of the script it started deleting all my files, it seems. Not sure what has changed. Perhaps it cleans up files that were unchanged? That doesn't seem right. I then proceeded to run the flow again but against a fresh directory (thanks APFS for not destroying my storage space), and this is the result: |
This appears to be a bug with Did you redirect the output of the test command to a file per the example? If you have the file please send it to me at osxphotos.py@gmail.com -- what I'm looking for is why osxphotos is calling the photokit code. I've not been able to replicate this. I'll take a look at the profile data you posted and see if anything jumps out.
That's possible. One more datapoint -- please run |
|
The next time you run your normal export command, please add the |
|
Got it. |
My guess is that the slowness was due having to download the files from iCloud (which is the intent of the |
|
Shared the reports over email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using the option
--download-missing --use-photokitthe process appears to be taking considerably more time.My library is 95% stored locally. I have around 2500 "downloading originals" still in process from an 80,000 library, so I doubt that's the root cause, but it's possible.
The difference is around 10 minutes to sync the full library without these parameters compared to over 4 hours since the new sync began, and around 5 hours left to the process, so an estimated 9 hours to complete.
This is the command I used:
App version:
The text was updated successfully, but these errors were encountered: