Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ensure parser/Combiner components are immutable #3653

Open
chenlizhong opened this issue Jan 13, 2023 · 0 comments
Open

Feature: ensure parser/Combiner components are immutable #3653

chenlizhong opened this issue Jan 13, 2023 · 0 comments

Comments

@chenlizhong
Copy link
Contributor

The Parser components are to parse the content of files or output of commands. The dependence is as below.

Files/output of Command -------> DataSource ------> Parser

Suggest to ensure the Parser components are immutable. The reasons are as below:

  1. The objects of Parsers are standing for the content of files or output of commands. it must reflect original values in files or commands.
  2. The objects of Parsers are shared dependence of Combiners/Conditions. If someone updated the object of one Parser casually in one Condition, it will impact all following Conditions

According above second reason, Combiner class need be immutable also.

Welcome any comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant