Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser EtcSshConfigD (spec ssh_config_d) doesn't indicate if collected and no files are present, or if collection disabled. #3527

Open
jsvob opened this issue Sep 19, 2022 · 0 comments

Comments

@jsvob
Copy link
Member

jsvob commented Sep 19, 2022

Expected behavior

Parser EtcSshConfigD (spec ssh_config_d) has a mechanism to indicate these two separate concepts:

  • Collection of specs.ssh_config_d is enabled by insights-client.
  • There are files in /etc/ssh/ssh_config.d / there are no files in /etc/ssh/ssh_config.d

Current behavior

Parser EtcSshConfigD (spec ssh_config_d) skips if either of these two conditions happen:

  • Collection of specs.ssh_config_d is not enabled by insights-client.
  • There are no files in /etc/ssh/ssh_config.d

This makes it impossible to tell whether the collection is disabled (OK thing for one of the consumers of the parser) or whether the contents of /etc/ssh/ssh_config.d were deleted (not OK thing for one of the consumers of the parser).

EDIT: Added the missing word "not" (marked in bold).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant