Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

high severity vulnerability #18

Open
sxzctzppyw opened this issue Jan 28, 2021 · 4 comments
Open

high severity vulnerability #18

sxzctzppyw opened this issue Jan 28, 2021 · 4 comments

Comments

@sxzctzppyw
Copy link

Hi,
Please see screenshot.
It says: found 1 high severity vulnerability in 1612 scanned packages
Zrzut ekranu 2021-01-24 161505

@kb3eua
Copy link

kb3eua commented Feb 14, 2021

Duplicate of RealFaviconGenerator/rfg-api#23

@rohan-deshpande
Copy link

You can get around this by using npx ie., in an npm script:

npx cli-real-favicon generate ./path/to/favicon/description.json ./path/to/favicon/data.json ./path/to/favicon

@kb3eua
Copy link

kb3eua commented Mar 25, 2021

@rohan-deshpande That does not address the issue on any level. Just using npx does not magically make rfg-api use a newer version of axios... the vulnerability is still there.

@rohan-deshpande
Copy link

rohan-deshpande commented Mar 25, 2021

Since the security vulnerability is related to the usage of a proxy in axios requests axios/axios#3369 I would say that actually this is a non issue because rfg-api doesn't even use a proxy https://github.com/RealFaviconGenerator/rfg-api/blob/master/index.js#L40

If you read the related issue you'd see that this is basically confirmed axios/axios#3369 (comment)

This is why using npx is helpful, because you don't get a non-issue warning in your npm audit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants