From bd29dede7c81598192595b8f222ec89392ed1f82 Mon Sep 17 00:00:00 2001 From: Ben Lesh Date: Sat, 3 Dec 2022 13:18:18 -0600 Subject: [PATCH] chore: Update to valid, active Node versions We had an issue where older, unsupported node versions were choking on the npm install script for latest npm. We needed to update our node versions --- .github/workflows/ci_main.yml | 56 ++++++++++++++---------------- .github/workflows/ci_ts_latest.yml | 24 ++++++------- 2 files changed, 38 insertions(+), 42 deletions(-) diff --git a/.github/workflows/ci_main.yml b/.github/workflows/ci_main.yml index dfff70898b..4b677ac79c 100644 --- a/.github/workflows/ci_main.yml +++ b/.github/workflows/ci_main.yml @@ -6,39 +6,37 @@ on: jobs: build: - runs-on: ubuntu-latest strategy: matrix: - node: [ '12', '13', '14', '15', '16' ] + node: ['14', '16', '18'] name: Node ${{ matrix.node }} build steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 - with: - node-version: ${{ matrix.node }} - - name: install - run: | - npm install -g npm@latest - npm ci - - name: lint - run: npm run lint - - name: build - run: npm run build:package - - name: test - run: | - npm test - npm run test:side-effects - - name: dtslint - run: npm run dtslint - - name: api_guardian - run: npm run api_guardian - - name: import - if: ${{ matrix.node == '14' }} - run: npm run test:import - - name: import - if: ${{ matrix.node == '14' || matrix.node == '15' }} - run: npm run test:esm - + - uses: actions/checkout@v2 + - uses: actions/setup-node@v1 + with: + node-version: ${{ matrix.node }} + - name: install + run: | + npm install -g npm@latest + npm ci + - name: lint + run: npm run lint + - name: build + run: npm run build:package + - name: test + run: | + npm test + npm run test:side-effects + - name: dtslint + run: npm run dtslint + - name: api_guardian + run: npm run api_guardian + - name: import + if: ${{ matrix.node == '14' }} + run: npm run test:import + - name: import + if: ${{ matrix.node == '14' || matrix.node == '15' }} + run: npm run test:esm diff --git a/.github/workflows/ci_ts_latest.yml b/.github/workflows/ci_ts_latest.yml index 2ea5910a90..802b611042 100644 --- a/.github/workflows/ci_ts_latest.yml +++ b/.github/workflows/ci_ts_latest.yml @@ -6,23 +6,21 @@ on: jobs: build: - runs-on: ubuntu-latest strategy: matrix: - node: [ '14' ] + node: ['18'] name: ts@latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 - with: - node-version: ${{ matrix.node }} - - name: build - run: | - npm install -g npm@latest - npm ci - npm install --legacy-peer-deps --no-save typescript@latest tslib@latest @types/node@latest - npm run compile - + - uses: actions/checkout@v2 + - uses: actions/setup-node@v1 + with: + node-version: ${{ matrix.node }} + - name: build + run: | + npm install -g npm@latest + npm ci + npm install --legacy-peer-deps --no-save typescript@latest tslib@latest @types/node@latest + npm run compile