Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive in deprecation with mergMap #7457

Closed
mcfdez opened this issue Mar 15, 2024 · 1 comment
Closed

False positive in deprecation with mergMap #7457

mcfdez opened this issue Mar 15, 2024 · 1 comment

Comments

@mcfdez
Copy link

mcfdez commented Mar 15, 2024

Describe the bug

When implementing the use of mergMap in Angular Ngrx effects, ESLint warns about the deprecated use of mergMap even if the operator is used correctly.

Expected behavior

The deprecation message should not appear when the operator is used correctly.

Reproduction code

export const deleteAddon = createEffect(
    (actions$ = inject(Actions), repository: AddonsRepository = inject(ADDONS_REPOSITORY)) => {
        return actions$.pipe(
            ofType(DeleteAddon),
            // This mergeMap alerts for deprecation!!
            mergeMap(({ id }) => deleteAddonUseCase(repository, id).pipe(
                map(() => DeleteAddonSuccess()),
            )),
        );
    },
    { functional: true },
);

Reproduction URL

No response

Version

7.8.1

Environment

No response

Additional context

No response

@benlesh
Copy link
Member

benlesh commented Apr 16, 2024

I can't confirm this in 7.x or 8.x.

@benlesh benlesh closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants