feat(pipe): signature for arbitrary array of T->T operations

[jeengbe]

Description:

Sometimes, you have an array of MonoTypeOperatorFunction<T> (e.g. a list of independent filters), and currently the only way of doing this is as follows:

// @ts-expect-error -- RxJS provides no signature for 'pipe<T>(...operations: readonly MonoTypeOperatorFunction<T>[]): Observable<T>;'
.pipe(...filters)

This PR adds an additional signature for this use-case.

Related issue:

Maybe #3989

[jeengbe]

Hi @ whoever approved the pipeline

the issue is not mine but something with the pipeline

Error: node_modules/typescript/lib/lib.es2015.collection.d.ts(62,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.iterable.d.ts(162,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts(140,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/@types/lodash/index.d.ts(372,15): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.collection.d.ts(62,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.iterable.d.ts(162,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts(140,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/@types/lodash/index.d.ts(372,15): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.collection.d.ts(62,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.iterable.d.ts(162,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts(140,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/@types/lodash/index.d.ts(372,15): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.collection.d.ts(62,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.iterable.d.ts(162,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts(140,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/@types/lodash/index.d.ts(372,15): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.collection.d.ts(62,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.iterable.d.ts(162,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts(140,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/@types/lodash/index.d.ts(372,15): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.collection.d.ts(62,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.iterable.d.ts(162,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts(140,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/@types/lodash/index.d.ts(372,15): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.collection.d.ts(62,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.iterable.d.ts(162,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts(140,11): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: node_modules/@types/lodash/index.d.ts(372,15): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
Error: Process completed with exit code 1.

[benlesh]

I think the updated CI rules for our master branch are conflicting with this branch. We'll take a look soon.

[JamesHenry]

All current issues on the 7.x branch relate to the same problem - the code has stayed the same, but it is trying to be run with tooling which has since evolved. This PR fixes the existing issues:

#7398

If @benlesh agrees with the rationale/approach it can be merged before this one and this one rebased on top

[benlesh]

Yeah if you rebase, everything will run now. Thank you, @JamesHenry .

[jeengbe]

Let's try the pipeline again 🙂

[jeengbe]

This time 🚀

[jeengbe]

Let's run it once more 🙂 @benlesh

[jeengbe]

Time to run it locally and wait for npm... I had aborted the clone at 100MB and hoped the code would work out of the box. Sorry for the inconvenience.

[jeengbe]

Hmm It's an issue with TS 4

That's the supposedly failing test

ERROR: /home/jeengbe/rxjs/spec-dtslint/Observable-spec.ts:86:5 - Expected type to be: Observable<"foo">; got: Observable<string>

[jeengbe]

Now; success guaranteed 🙂

[benlesh]

We'll need to have the same PR merged to master first, or it's technically a regression. (if 7.x supports this but 8.x does not)

[jeengbe]

Are these types still an issue with 8.x?