Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose options types publicly #7336

Closed
benlesh opened this issue Sep 12, 2023 · 2 comments
Closed

Expose options types publicly #7336

benlesh opened this issue Sep 12, 2023 · 2 comments
Labels
8.x Issues and PRs for version 8.x AGENDA ITEM Flagged for discussion at core team meetings help wanted Issues we wouldn't mind assistance with.

Comments

@benlesh
Copy link
Member

benlesh commented Sep 12, 2023

I ran across userland code recently where the developer had to copy the BasicGroupByOptions interface into their own code because we don't expose it. If we have an interface for an options/config argument, we should be exposing that type so people can use it.

We'll probably want to make sure their naming convention is consistent prior to exposure.

@benlesh benlesh added help wanted Issues we wouldn't mind assistance with. 8.x Issues and PRs for version 8.x labels Sep 12, 2023
@jakovljevic-mladen
Copy link
Member

jakovljevic-mladen commented Sep 12, 2023

But we do expose this interface since v7 🙈. (Which version does the mentioned repo use?)

We expose a lot of configuration interfaces and one of the reasons we do is because the docs app would required them exposed so it can show them in the app. For more info, please check this PR.

I found a couple of PRs where many such interfaces are exposed:

@jakovljevic-mladen jakovljevic-mladen added the AGENDA ITEM Flagged for discussion at core team meetings label Nov 1, 2023
@benlesh
Copy link
Member Author

benlesh commented Nov 15, 2023

Mkay

@benlesh benlesh closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.x Issues and PRs for version 8.x AGENDA ITEM Flagged for discussion at core team meetings help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Development

No branches or pull requests

2 participants