Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We forgot to deprecate the resultSelector for combineLatest #7169

Open
benlesh opened this issue Jan 24, 2023 · 3 comments
Open

We forgot to deprecate the resultSelector for combineLatest #7169

benlesh opened this issue Jan 24, 2023 · 3 comments
Assignees

Comments

@benlesh
Copy link
Member

benlesh commented Jan 24, 2023

As mentioned here: #7168

I think the code in that section was sufficiently complicated as to obscure that we forgot to deprecate that signature.

That gives us two options:

  1. Deprecated it now and wait until v9. (Maybe a year?)
  2. Just remove it as part of the set of breaking changes in v8.

I'm fine with either, but I'm a little sad if we have to leave it, I was hoping to clean everything up this version.

@benlesh benlesh added the AGENDA ITEM Flagged for discussion at core team meetings label Jan 24, 2023
@demensky
Copy link
Contributor

When I was doing #7156, I was even surprised that it was not marked as @deprecated. I thought that it is needed as well as in fromEvent. But map handles this nicely. Replacing resultSelector with map is pretty easy, so I suggest option 2.

@demensky
Copy link
Contributor

What about zip & forkJoin?

@benlesh benlesh removed the AGENDA ITEM Flagged for discussion at core team meetings label Feb 8, 2023
@benlesh
Copy link
Member Author

benlesh commented Feb 8, 2023

CORE TEAM: We should be responsible and deprecate until v9. :( Boooo

@benlesh benlesh self-assigned this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants