Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Productize operator creation internals #6803

Closed
benlesh opened this issue Feb 7, 2022 · 1 comment
Closed

Productize operator creation internals #6803

benlesh opened this issue Feb 7, 2022 · 1 comment
Labels
8.x Issues and PRs for version 8.x

Comments

@benlesh
Copy link
Member

benlesh commented Feb 7, 2022 •
edited

For version 8, we should try to productize our operator creation methods to give people something more terse, and perhaps more safe, to create their own operators.
@benlesh benlesh added the 8.x Issues and PRs for version 8.x label Feb 7, 2022
This was referenced Feb 7, 2022
Open
Merged
benlesh added a commit to benlesh/rxjs that referenced this issue Feb 7, 2022
@benlesh
refactor: remove GroupBySubscriber
f7cb40f 
Adds a special case to `OperatorSubscriber` to support `groupBy`.

Related: ReactiveX#6805 ReactiveX#6803 ReactiveX#6804
@benlesh benlesh mentioned this issue Feb 7, 2022
Merged
benlesh added a commit that referenced this issue Feb 8, 2022
@benlesh
refactor: remove GroupBySubscriber (#6806)
e43063a 
Adds a special case to `OperatorSubscriber` to support `groupBy`.

Related: #6805 #6803 #6804
@benlesh benlesh mentioned this issue Feb 8, 2022
Closed
benlesh added a commit to benlesh/rxjs that referenced this issue Feb 8, 2022
@benlesh
feat: Allow operators to operate on any Subscribable without lift
a62df92 
* Adds a code path for operating on a Subscribable without lift.
* Loosens the type of `OperatorFunction` and therefore `MonoTypeOperatorFunction` to go from `Subscribable<In>` to `Subscribable<Out>`.

This is done in preparation for splitting `Observable` into its own package, where `lift` doesn't really need to exist in the public API.

Related ReactiveX#6803 ReactiveX#6786
@benlesh benlesh mentioned this issue Feb 8, 2022
Closed
@benlesh
Copy link
Member Author

benlesh commented Jan 4, 2024

This is effectively in place now for 8.x

@benlesh benlesh closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8.x Issues and PRs for version 8.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benlesh