Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we're properly supporting ESM in Node #6030

Open
benlesh opened this issue Feb 17, 2021 · 2 comments
Open

Ensure we're properly supporting ESM in Node #6030

benlesh opened this issue Feb 17, 2021 · 2 comments
Projects
Core Issues Triage

Comments

@benlesh
Copy link
Member

benlesh commented Feb 17, 2021

See the write up by @Rich-Harris here:

d3/d3#3469
@benlesh
Copy link
Member Author

benlesh commented Feb 17, 2021

(cries internally)

@benlesh benlesh mentioned this issue Feb 17, 2021
Open
@benlesh benlesh added this to Low priority in Core Issues Triage Feb 22, 2021
@calebboyd calebboyd mentioned this issue Feb 22, 2021
Closed
@tomastrajan
Copy link

It would be great (and compliant) if rxjs shipped

dist/esm/*.mjs

instead if

dist/esm/*.js

(ie use .mjs extension, but only in esm folders)

The reson for this is that some tooling assumes (correctly) that .js means it's .cjs (in the absence of "type": "module" in the nearest package.json) and breaks and there is no way to override this behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Core Issues Triage
Low priority
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benlesh @tomastrajan