Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflicting types with @types/node v12 #5964

Closed
jsaguet opened this issue Jan 18, 2021 · 2 comments
Closed

conflicting types with @types/node v12 #5964

jsaguet opened this issue Jan 18, 2021 · 2 comments

Comments

@jsaguet
Copy link

jsaguet commented Jan 18, 2021

Bug Report

I don't know if there is a solution for this since it seems to be linked with @types/node version but I'm reporting it anyway just in case.

Current Behavior
When running karma tests in an angular project using @types/node v12, I get the following conflicting types error:

Error: node_modules/rxjs/dist/types/internal/types.d.ts:17:18 - error TS2717: Subsequent property declarations must have the same type.  Property 'observable' must be of type 'symbol', but here has type 'unique symbol'.

         readonly observable: unique symbol;


  node_modules/@types/node/globals.d.ts:146:14
         readonly observable: symbol;

    'observable' was also declared here.

When switching to @types/node >=13.1.0 there is no error anymore.

Expected behavior
Error should not be present.

Environment

  • Runtime: Node v12
  • RxJS version: 7.0.0-beta.10
  • @types/node ^12.0.0
@kwonoj
Copy link
Member

kwonoj commented Jan 18, 2021

It's breaking change listed in https://github.com/ReactiveX/rxjs/blob/master/CHANGELOG.md#700-beta9-2020-12-07 and partially leftover issue is filed at #5919 .

@kwonoj kwonoj closed this as completed Jan 18, 2021
@jsaguet
Copy link
Author

jsaguet commented Jan 18, 2021

Damn, I read the changelog and missed this item. Thanks for pointing that out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants