Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Specify proper OSGi unique bundle symbolic name #7319

Merged
merged 1 commit into from Aug 25, 2021

Conversation

akarnokd
Copy link
Member

The default was just the ArtifactID of "rxjava" which could become a problem in future major versions.

In addition, in the description, the unicode dash is now replaced with the ASCII dash to avoid encoding problems.

Related: #7318

@akarnokd akarnokd added this to the 3.1-support milestone Aug 24, 2021
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #7319 (e2fefee) into 3.x (3e77f5c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7319      +/-   ##
============================================
- Coverage     99.56%   99.55%   -0.01%     
+ Complexity     6784     6783       -1     
============================================
  Files           751      751              
  Lines         47490    47490              
  Branches       6378     6378              
============================================
- Hits          47284    47281       -3     
+ Misses           95       92       -3     
- Partials        111      117       +6     
Impacted Files Coverage Δ
...ternal/operators/completable/CompletableMerge.java 97.29% <0.00%> (-2.71%) ⬇️
...nternal/operators/observable/ObservableCreate.java 96.58% <0.00%> (-2.57%) ⬇️
...ternal/operators/observable/ObservablePublish.java 97.29% <0.00%> (-1.81%) ⬇️
...nternal/operators/observable/ObservableWindow.java 98.21% <0.00%> (-1.79%) ⬇️
...3/internal/operators/flowable/FlowablePublish.java 99.00% <0.00%> (-1.00%) ⬇️
...perators/observable/ObservableMergeWithSingle.java 99.05% <0.00%> (-0.95%) ⬇️
...ternal/operators/observable/ObservableFlatMap.java 97.87% <0.00%> (-0.71%) ⬇️
...3/internal/operators/observable/ObservableZip.java 99.31% <0.00%> (-0.69%) ⬇️
...rnal/operators/flowable/FlowableFlatMapSingle.java 95.93% <0.00%> (-0.59%) ⬇️
.../reactivex/rxjava3/observers/BaseTestConsumer.java 99.46% <0.00%> (-0.54%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e77f5c...e2fefee. Read the comment docs.

@akarnokd akarnokd merged commit 9de33ea into ReactiveX:3.x Aug 25, 2021
@akarnokd akarnokd deleted the 3xOsgiFixBundleSymbolicName branch August 25, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants