Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error messages of parameter checks consistent #6433

Merged

Conversation

lorenzpahl
Copy link
Contributor

This PR updates error messages of parameter checks. Most of the changes are due to the renaming of a parameter without changing the error message used when the parameter check fails.

@codecov
Copy link

codecov bot commented Mar 16, 2019

Codecov Report

Merging #6433 into 2.x will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6433      +/-   ##
============================================
+ Coverage     98.24%   98.27%   +0.03%     
- Complexity     6294     6295       +1     
============================================
  Files           675      675              
  Lines         45172    45171       -1     
  Branches       6246     6246              
============================================
+ Hits          44380    44394      +14     
+ Misses          250      242       -8     
+ Partials        542      535       -7
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <100%> (ø) 567 <16> (ø) ⬇️
src/main/java/io/reactivex/Completable.java 100% <100%> (ø) 120 <1> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <100%> (ø) 542 <20> (ø) ⬇️
src/main/java/io/reactivex/Maybe.java 100% <100%> (ø) 173 <4> (ø) ⬇️
src/main/java/io/reactivex/Single.java 100% <100%> (ø) 149 <5> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 89.54% <0%> (-6.54%) 2% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 92.7% <0%> (-2.19%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...activex/internal/schedulers/ScheduledRunnable.java 98.07% <0%> (-1.93%) 29% <0%> (-1%)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb7b4d...ea4ce41. Read the comment docs.

@akarnokd akarnokd merged commit b3d7f5f into ReactiveX:2.x Mar 21, 2019
@lorenzpahl lorenzpahl deleted the chore/inconsistent-error-messages branch March 21, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants