Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: Fix take() to route late errors to RxJavaHooks #5935

Merged
merged 1 commit into from Mar 26, 2018

Conversation

akarnokd
Copy link
Member

If there is a late exception after take has unsubscribed from the upstream, this exception was ignored by the operator. This fix makes sure such late exceptions are routed to the RxJavaHooks.onError handler, just like 2.x does.

Fixes: #5934.

@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #5935 into 1.x will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.x    #5935      +/-   ##
============================================
- Coverage     84.13%   84.13%   -0.01%     
  Complexity     2897     2897              
============================================
  Files           291      291              
  Lines         18562    18563       +1     
  Branches       2554     2554              
============================================
  Hits          15618    15618              
  Misses         2029     2029              
- Partials        915      916       +1
Impacted Files Coverage Δ Complexity Δ
.../main/java/rx/internal/operators/OperatorTake.java 90.9% <100%> (+0.21%) 4 <0> (ø) ⬇️
...n/java/rx/subjects/SubjectSubscriptionManager.java 73.57% <0%> (-7.86%) 16% <0%> (ø)
...ain/java/rx/internal/schedulers/SchedulerWhen.java 83.78% <0%> (-4.06%) 4% <0%> (ø)
.../java/rx/internal/operators/BackpressureUtils.java 70.45% <0%> (-2.28%) 28% <0%> (-1%)
src/main/java/rx/subjects/UnicastSubject.java 82.71% <0%> (-0.62%) 9% <0%> (ø)
...main/java/rx/internal/operators/OperatorMerge.java 85.77% <0%> (-0.46%) 7% <0%> (ø)
...ain/java/rx/internal/operators/OperatorReplay.java 82.38% <0%> (-0.4%) 15% <0%> (ø)
...in/java/rx/internal/operators/OperatorPublish.java 78.33% <0%> (+0.41%) 8% <0%> (ø) ⬇️
...ternal/operators/OperatorOnBackpressureBuffer.java 95% <0%> (+1.25%) 8% <0%> (ø) ⬇️
src/main/java/rx/observables/SyncOnSubscribe.java 93.28% <0%> (+1.49%) 8% <0%> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0641802...a10d8dc. Read the comment docs.

@akarnokd akarnokd merged commit 3aad9a6 into ReactiveX:1.x Mar 26, 2018
@akarnokd akarnokd deleted the TakeReportLateErrorToHook branch March 26, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants