Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyfill Element for Node #6607

Merged
merged 2 commits into from Mar 3, 2019
Merged

Polyfill Element for Node #6607

merged 2 commits into from Mar 3, 2019

Conversation

pshrmn
Copy link
Contributor

@pshrmn pshrmn commented Mar 2, 2019

Element is DOM only.

@pshrmn pshrmn mentioned this pull request Mar 2, 2019
Merged
@pshrmn pshrmn mentioned this pull request Mar 2, 2019
Closed
@timdorr timdorr merged commit f4081ae into master Mar 3, 2019
@pshrmn pshrmn deleted the element-polyfill branch March 3, 2019 01:56
@wellyshen wellyshen mentioned this pull request Mar 9, 2019
Closed
@wmertens
Copy link
Contributor

It's not nice to randomly polyfill things in Node - how about just fixing the proptypes calls to not use Element if it doesn't exist?

@pshrmn
Copy link
Contributor Author

pshrmn commented Mar 15, 2019

Polyfill was a poor choice of words by myself; the definition is contained locally. That said, it has already been rewritten to use a more generic prop type.

https://github.com/ReactTraining/react-router/blob/4736cfe01dc71b6fa69b76ab946b6205447c3faa/packages/react-router-dom/modules/Link.js#L65

@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pshrmn @wmertens @timdorr @serchavalos