Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to grab images: Failed to extract images from embedded JS on generic physical page #521

Open
HibiscusKazeneko opened this issue Jul 14, 2022 · 5 comments
Labels

Comments

@HibiscusKazeneko
Copy link

I've been getting this error message fairly frequently when attempting to import cover art from Amazon pages. It seems to be an issue with newer listings.

@ROpdebee
Copy link
Owner

Do you have an example of a URL on which it fails? That'll make it much easier to figure out what the issue is. Thanks!

@HibiscusKazeneko
Copy link
Author

https://www.amazon.com/gp/product/B0B2F6TV5P was affected at the time I posted this thread. It appears to have fixed itself.

@ROpdebee ROpdebee added bug Something isn't working mb_enhanced_cover_art_uploads labels Jul 14, 2022
@ROpdebee
Copy link
Owner

Hmm, strange that it fixed itself. It could be that the script landed on a captcha page due to rate limiting etc. Someone (probably me) should investigate to see 1) if we can figure out why it's actually failing to parse the page and 2) if we can either fix it or improve the error message if it turns out to be unfixable.

@HibiscusKazeneko
Copy link
Author

This issue is back with a vengeance. For the past several hours I have received this exact error message every time I try to import cover art for a physical release. It's the same for older and newer releases.

@ROpdebee
Copy link
Owner

I've pushed an update that'll improve the error message in case it hits rate limiting with a captcha. I'm not sure that it's caused by captchas though, because I haven't been able to reproduce it yet.

I've also got some work in progress that should improve the "debugability" of the script in case it hits weird errors. It needs a bit more work to be usable, and I can't really give an ETA on when it'll land, but when it does, I'll be able to look at this in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants