Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The generateBundle hook should be used instead of the onwrite hook. #3

Closed
javadbat opened this issue Jan 21, 2019 · 7 comments
Closed

Comments

@javadbat
Copy link

image

@rj-hwang
Copy link
Contributor

Which version of rollup do you use?

@javadbat
Copy link
Author

"rollup": "^1.1.1",
"rollup-plugin-css-porter": "^0.2.0",
"rollup-plugin-node-resolve": "^4.0.0"
"rollup-plugin-babel": "^4.3.2",
"rollup-plugin-babel-minify": "^7.0.0"

@rj-hwang
Copy link
Contributor

OK, I‘ll check it later.

@javadbat
Copy link
Author

do you check it?

@rj-hwang
Copy link
Contributor

So busy Recently, sorry for that. I had confirmed that this deprecated warning message appears after upgrade to rollup-1.0.0+. I'm working on it ASAP now.

@rj-hwang
Copy link
Contributor

rj-hwang commented Mar 12, 2019

Main code change :

  1. follow RFC: Standardise options and CLI flags #1479
    and Unifying Rollup options , since rollup-0.48.0, bundle.write(options) options.dest > option.file, entry > input. See 5519c45.
  2. follow rollup-1.0.0: deprecations #2409, use generateBundle instead onwrite. See 589dc4b.

@rj-hwang rj-hwang changed the title The onwrite hook used by plugin rollup-plugin-css-porter is deprecated. The generateBundle hook should be used instead. The generateBundle hook should be used instead of the onwrite hook. Mar 12, 2019
@rj-hwang
Copy link
Contributor

Release 1.0.0 to fix this issue.

Please check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants