Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdflib-jsonld is still a dependency of version 0.17.0 #95

Closed
tcmitchell opened this issue Sep 14, 2021 · 3 comments
Closed

rdflib-jsonld is still a dependency of version 0.17.0 #95

tcmitchell opened this issue Sep 14, 2021 · 3 comments

Comments

@tcmitchell
Copy link
Contributor

The release notes for v0.17.0 imply that rdflib-jsonld is no longer a dependency. And I see issue #93 ("Remove (soft)dependency on rdflib_jsonld") and merged pull request #94 ("Remove dependency on rdflib-jsonld"). Yet v0.17.0 still lists rdflib-jsonld as a dependency:

$ pip show pyshacl
Name: pyshacl
Version: 0.17.0
Summary: Python SHACL Validator
Home-page: https://github.com/RDFLib/pySHACL
Author: Ashley Sommer
Author-email: Ashley.Sommer@csiro.au
License: Apache-2.0
Location: /Users/tmitchel/Projects/sd2/pySBOL3/venv/lib/python3.8/site-packages
Requires: rdflib-jsonld, owlrl, rdflib
Required-by: 

It took me quite a while to track down which dependency of mine was including rdflib-jsonld and I was surprised to see, given the recent changes here, that rdflib-jsonld is still listed as a dependency. Should it be?

@ashleysommer
Copy link
Collaborator

Hi @tcmitchell, you're right, rdflib_jsonld should definitely not be listed as a dependency.
PySHACL releases v0.16.2.post1 and v0.17.0 both changed json-ld to an optional dependency.

See:

rdflib-jsonld = { version=">=0.4.0,<0.6", optional=true}

@ashleysommer
Copy link
Collaborator

Ok, looks like Poetry doesn't quite support optional extras in that sense. See:
python-poetry/poetry#2749

I'll have to add an extras package that points to it. Easy enough, then I'll do a new release (v0.16.2.post2 and v0.17.0.post2)

@ashleysommer
Copy link
Collaborator

Ok, versions v0.16.2.post2 and v0.17.0.post2 are now published, which resolves that error. Sorry for the mixup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants