Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disconnect command shouldn't be FCVAR_SERVER_CAN_EXECUTE #553

Open
ASpoonPlaysGames opened this issue Sep 16, 2023 · 2 comments · May be fixed by #663
Open

disconnect command shouldn't be FCVAR_SERVER_CAN_EXECUTE #553

ASpoonPlaysGames opened this issue Sep 16, 2023 · 2 comments · May be fixed by #663
Labels
bug Something isn't working

Comments

@ASpoonPlaysGames
Copy link
Contributor

We already have a function for disconnecting people properly, so we should use that in script instead.

This allows people to disconnect others via kill replays and such

offending line:
https://github.com/R2Northstar/NorthstarLauncher/blob/main/NorthstarDLL/shared/misccommands.cpp#L189C44-L189C44
@ASpoonPlaysGames ASpoonPlaysGames added the bug Something isn't working label Sep 16, 2023
@F1F7Y
Copy link
Member

F1F7Y commented Sep 17, 2023

On another note disconnect can just be ignored by the client so CClient::Disconnect ( or script equivalent NSDisconnectPlayer ) should always be used to make sure the client is actually disconnected

@F1F7Y F1F7Y mentioned this issue Sep 17, 2023
Merged
@r3muxd
Copy link

r3muxd commented Oct 17, 2023

This allows people to disconnect others via kill replays and such

wrong

@ASpoonPlaysGames ASpoonPlaysGames linked a pull request Feb 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Northstar Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove FCVAR_SERVER_CAN_EXECUTE from disconnect ASpoonPlaysGames/NorthstarLauncher
3 participants
@r3muxd @F1F7Y @ASpoonPlaysGames