Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃悶] Version 1.5.3 build is broken: Cannot load native addon because loading addons is disabled #6223

Open
ohkimur opened this issue May 4, 2024 · 11 comments
Assignees
Labels
COMP: optimizer P4: urgent If Bug - it makes Qwik unstable and affects the majority of users TYPE: bug Something isn't working

Comments

@ohkimur
Copy link

ohkimur commented May 4, 2024

Which component is affected?

Qwik Rollup / Vite plugin

Describe the bug

Starting with v1.5.3 the vite build fails. This fails in a few different environments, including the official vite template for qwik. Check it out here.

Also, starting with this version, qwik doesn't respect custom rollup configs from vite properly, including custom dir, and entryFileName options.

NOTE: I'm working on a very big design system that supports all the major frameworks including qwik. For each one of them I build to dist. It would be great to be able to keep doing this for qwik.

Reproduction

https://stackblitz.com/edit/vitejs-vite-zyuten?file=package.json

Steps to reproduce

No response

System Info

System:
    OS: macOS 14.4.1
    CPU: (16) arm64 Apple M3 Max
    Memory: 8.46 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.7.2 - ~/.nvm/versions/node/v21.7.2/bin/node
    npm: 10.5.0 - ~/.nvm/versions/node/v21.7.2/bin/npm
    pnpm: 9.0.6 - ~/Library/pnpm/pnpm
    bun: 1.0.35 - ~/.bun/bin/bun
  Browsers:
    Chrome: 124.0.6367.119
    Safari: 17.4.1

Additional Information

No response

@ohkimur ohkimur added STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working labels May 4, 2024
@PatrickJS
Copy link
Member

it might have been caused by
#6178
or
#6162

what do you think @wmertens

@PatrickJS
Copy link
Member

@ohkimur can you stay on 1.5.2 until we fix it

@PatrickJS
Copy link
Member

csr: true will be fixed in next release #6292

@wmertens
Copy link
Member

Ah and the dlopen issue is separate because now we ship a binary from Linux and it tries to use it in stackblitz.

So we need to be more careful about that.

@wmertens wmertens added COMP: optimizer P4: urgent If Bug - it makes Qwik unstable and affects the majority of users and removed STATUS-1: needs triage New issue which needs to be triaged labels May 11, 2024
@JerryWu1234
Copy link
Contributor

What can I do here ?

@PatrickJS PatrickJS assigned JerryWu1234 and unassigned wmertens May 20, 2024
@PatrickJS
Copy link
Member

@wmertens you can outline what @JerryWu1234 can do 馃檶

@ohkimur
Copy link
Author

ohkimur commented May 28, 2024

@PatrickJS Do we have any update on this topic? I'm wondering if there's something I could help with. I see the vite-demo still is failing to compile. The same happens still when I update to v1.5.5.

@PatrickJS
Copy link
Member

@wmertens is the only one with enough context on what to fix here

@wmertens
Copy link
Member

This is a cosmetic error. It shows that and then it uses wasm instead. I have a fix already but it's in a PR that's blocked right now, I'll add it separately when I get a chance.

@ohkimur
Copy link
Author

ohkimur commented May 28, 2024

@wmertens Can you mention me in the PR? I'd like to take a look and understand the problem deeper if possible.

@wmertens
Copy link
Member

@ohkimur it's this commit 2b5384c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: optimizer P4: urgent If Bug - it makes Qwik unstable and affects the majority of users TYPE: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants