Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic extract script and style tags from html token content #26

Merged
merged 3 commits into from Jul 27, 2017

Conversation

rlsz
Copy link
Contributor

@rlsz rlsz commented Jul 27, 2017

Add ruler: automatic extract script and style tags from html token content.
Script will be excuted, and style will be added to ducument head.
No need to write script code and style code twice.
#2 --this issue could be avoided.

add ruler:extract script and style tags from html token content
@huangshuwei
Copy link

I have already started using it.
it's really a good PR

@QingWei-Li
Copy link
Owner

Cool. I will test it tonight.

@rlsz
Copy link
Contributor Author

rlsz commented Jul 27, 2017

Hold on.
I just found reg "<(script|style)[^<]*</\1>" confused special chars '<' or "</script>" or "</style>".
If script scope has a string type variable which content those chars, error appears.
Reg is too complex to resolve this. Need more time.

rlsz added 2 commits July 27, 2017 20:25
fix bug: char '<' leads to error
update commentary
@QingWei-Li QingWei-Li merged commit 74fae7b into QingWei-Li:master Jul 27, 2017
@QingWei-Li
Copy link
Owner

v2.0.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants