Fix: thread name #302
Merged
Fix: thread name #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalresistor
force-pushed
the
fix/thread_name
branch
from
b0af32f
to
ea0b34a
Compare
This way loggers that use the thread name display useful information
digitalresistor
force-pushed
the
fix/thread_name
branch
from
ea0b34a
to
7a03297
Compare
|
@mmerickel I think that this change is uncontroversial, but would like your thoughts on it or if you feel strongly about it. I'd like to get this merged, get a new release out with those latest buffer changes, and then I am going to try and merge my Py3 only work into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere along the lines the thread name got set to just
waitressrather than something that identifies thread number it is, this adds the thread number back to the name of the thread.