Python 3 only -- fixes deprecation warnings #63
Conversation
digitalresistor
force-pushed
the
py3-only
branch
from
54f0101
to
633bd8a
Compare
| if module is not None: | ||
| for name, ob in getmembers(module, None): | ||
| invoke(modname, name, ob) | ||
| get_filename = getattr(loader, 'get_filename', None) |
There was a problem hiding this comment.
Meat of the change here...
digitalresistor
force-pushed
the
py3-only
branch
from
633bd8a
to
f9eb29d
Compare
|
There is some weirdness going on with the venusian 2.0.0 release. This PR adds python_requires, but https://pypi.org/simple/venusian/ doesn't have it. I just tested running devpi-server tests with the py27 tox environment and it actually did install venusian 2.0.0, but it worked just fine. Is it possible the code path isn't relevant for clean tox runs? |
|
@fschulze you are correct. I apologise for this. I'm working on fixing it. |
|
@fschulze I don't know if the code path isn't relevant for |
|
@fschulze I've re-released |
|
Thanks! Indeed the tests don't trigger BTW, devpi-server is great for checking things like this before uploading to PyPI 😉 |
3.0.0 (2019-10-04) ------------------ - This release matches 2.0.0 other than in the version number. This fixes an issue with Requires-Python metadata not being uploaded correctly to PyPi. This version is only compatible with Python 3.5+ 2.0.0 (2019-10-04) ------------------ - Drop support for Python 2.7, 3.3, and 3.4 - Removed the usage of the ``imp`` module to squelch the warnings regarding a deprecated modules. See Pylons/venusian#63 and Pylons/venusian#57 1.2.0 (2019-01-08) ------------------ - Add support for Python 3.7. - Drop support for Python 3.3. 1.1.0 (2017-04-24) ------------------ - Updated to using py.test instead of nosetest, and added support for Python 3.4 -> 3.6 - Make scanning more resilient of metaclasses that return proxies for any attribute access. - Fix bug where using the same venusian decorator on both a class and its methods would cause the method decorations to be ignored. See Pylons/venusian#40 - Drop support for Python 2.6. - Drop support for Python 3.2: it is no longer supported by current packaging / CI tools. - Support loaders that require the module name as argument to their ``get_filename()`` method. This fixes problems with zipped packages on Python 3. - Micro-optimization when ignores are used (see Pylons/venusian#20). - A tox run now combines coverage between Py2 and Py3.
This updates the project in a couple of ways:
srcfolder structuresetup.cfginstead ofsetup.pyand addpyproject.tomltox.inistolen from various projectscompat.pyimpimport and fix the codeMANIFEST.inThis replaces #62 by just removing those code paths that depended on the constants. In the Python 3 world due to the use of
__pycache__we no longer need to protect against importing "orphaned" files. This is because it is perfectly valid to "ship".pycfiles and we do actually want to import them directly.There may be some more iterations that need to be done, to clean up the logic just a little bit, especially since I had to add some
# pragma: nocoveron certain branches that are not being hit on any of the interpreters I am testing on (py 3.5 -> py 3.8 and pypy3).Closes #57
Closes #62