Mark TransientError retryable #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you raise a TransientError subclass then your request *will* be retried but pyramid_retry functions like is_error_retryable() will return False. Mark TransientError as retryable so that is_error_retryable() correctly returns True. Fixes Pylons#70
|
Do you mind adding your name to CONTRIBUTORS.txt here and in your pyramid_retry PR? |
mmerickel
approved these changes
Sep 27, 2019
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you raise a
TransientErrorsubclass then your request will be retried but pyramid_retry functions likeis_error_retryable()will incorrectly returnFalse.Mark
TransientErroras retryable so thatis_error_retryable()correctly returnsTrue.Fixes #70