You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As described in #1545 (comment) we should add event= to the config.add_subscriber_predicate API to allow a different predicate per-event-type. This can be done with a simple adapter. We may be able to then register some default predicates for the builtin events.
Note the biggest issue is that BeforeRender exposes the request as event['request'] instead of event.request which is a big reason an adapter-based api is necessary, but also because events have no required format.
The text was updated successfully, but these errors were encountered:
This is what you currently have to do with no changes, and personally I find to be reasonable. I just opened this issue incase someone was offended by it and was looking for a way to improve things similar to the efforts in #1545.
As described in #1545 (comment) we should add
event=
to theconfig.add_subscriber_predicate
API to allow a different predicate per-event-type. This can be done with a simple adapter. We may be able to then register some default predicates for the builtin events.Note the biggest issue is that
BeforeRender
exposes therequest
asevent['request']
instead ofevent.request
which is a big reason an adapter-based api is necessary, but also because events have no required format.The text was updated successfully, but these errors were encountered: