Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using watchdog 2.1.4 #72

Closed
lelit opened this issue Aug 20, 2021 · 6 comments
Closed

Error using watchdog 2.1.4 #72

lelit opened this issue Aug 20, 2021 · 6 comments

Comments

@lelit
Copy link

lelit commented Aug 20, 2021

While hupper 1.10.3 works great with watchdog 2.1.3, with recently released 2.1.4 I get the following traceback:

Traceback (most recent call last):
  File "/usr/local/bin/pserve", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/site-packages/pyramid/scripts/pserve.py", line 34, in main
    return command.run()
  File "/usr/local/lib/python3.9/site-packages/pyramid/scripts/pserve.py", line 245, in run
    hupper.start_reloader(
  File "/usr/local/lib/python3.9/site-packages/hupper/reloader.py", line 489, in start_reloader
    return reloader.run()
  File "/usr/local/lib/python3.9/site-packages/hupper/reloader.py", line 138, in run
    with self._setup_runtime():
  File "/usr/local/lib/python3.9/contextlib.py", line 117, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.9/site-packages/hupper/reloader.py", line 179, in _setup_runtime
    with self._start_monitor():
  File "/usr/local/lib/python3.9/contextlib.py", line 117, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.9/site-packages/hupper/reloader.py", line 209, in _start_monitor
    self.monitor.start()
  File "/usr/local/lib/python3.9/site-packages/hupper/reloader.py", line 56, in start
    self.monitor.start()
  File "/usr/local/lib/python3.9/site-packages/watchdog/observers/api.py", line 254, in start
    for emitter in self._emitters.copy():
AttributeError: 'WatchdogFileMonitor' object has no attribute '_emitters'
@mmerickel
Copy link
Member

mmerickel commented Aug 20, 2021

Interesting... a quick review of the changes don't have anything that sticks out to me so I'll have to find some time to try to repro it.

gorakhargosh/watchdog@v2.1.3...v2.1.4

@lelit
Copy link
Author

lelit commented Aug 20, 2021

Right, I did the same before posting and didn't spot anything, sorry.

@BoboTiG
Copy link

BoboTiG commented Aug 23, 2021

Hello,

Sorry for the regression, I am working on a fix right now (gorakhargosh/watchdog#830).

@BoboTiG
Copy link

BoboTiG commented Aug 23, 2021

Watchdog 2.1.5 released with the fix :)

@lelit
Copy link
Author

lelit commented Aug 23, 2021

Thank you! Since I'm leaving for a short vacation, I won't be able to give feedback until September.

@digitalresistor
Copy link
Member

@BoboTiG thanks for the quick fix :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants