Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum options breaking with redesigned options #1359

Merged
merged 2 commits into from May 15, 2022

Conversation

Middledot
Copy link
Member

Summary

works:

async def toggle(self, ctx, opt: OnOffEnum):

doesn't work:

async def toggle(self, ctx, opt = OnOffEnum):

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Middledot Middledot added the bug Something isn't working label May 14, 2022
@krittick krittick merged commit 98c1f39 into Pycord-Development:master May 15, 2022
@Middledot Middledot deleted the enums-new-options branch June 26, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants