Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TextChannel._get_channel async #1358

Merged
merged 1 commit into from May 14, 2022
Merged

Make TextChannel._get_channel async #1358

merged 1 commit into from May 14, 2022

Conversation

Qxe5
Copy link
Contributor

@Qxe5 Qxe5 commented May 14, 2022

Summary

TextChannel._get_channel() is called with await but isn't defined as async

For example:

channel = await self._get_channel()

This leads to exceptions such as TypeError: object TextChannel can't be used in 'await' expression

This change is consistent with all other classes in the module such as VoiceChannel which do use async in the definition of _get_channel()

async def _get_channel(self):

async def _get_channel(self) -> MessageableChannel:

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Dorukyum Dorukyum changed the title fix bug Make TextChannel._get_channel async May 14, 2022
@Dorukyum Dorukyum merged commit dd62cc3 into Pycord-Development:master May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants