Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Refactor #1351

Merged
merged 1 commit into from May 14, 2022
Merged

Minor Refactor #1351

merged 1 commit into from May 14, 2022

Conversation

UP929312
Copy link
Contributor

@UP929312 UP929312 commented May 13, 2022

This should clean up the logic slightly, with it being slightly more readable in my opinion, and even though it might be faster with Python's EAFP logic, I think maintainability and readability is probably more important than this micro efficiency.

Summary

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

Please correct me if I'm wrong, but this should be better
@krittick krittick merged commit 485e26c into Pycord-Development:master May 14, 2022
@Middledot Middledot mentioned this pull request May 14, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants