Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix py3.10 UnionType checks #1240

Merged
merged 1 commit into from Apr 9, 2022
Merged

Fix py3.10 UnionType checks #1240

merged 1 commit into from Apr 9, 2022

Conversation

BobDotCom
Copy link
Member

Summary

Fixes an error

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@BobDotCom BobDotCom self-assigned this Apr 9, 2022
@BobDotCom BobDotCom added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer Merge with squash labels Apr 9, 2022
@BobDotCom BobDotCom added this to In progress in v2.0 via automation Apr 9, 2022
@BobDotCom BobDotCom added this to the v2.0 milestone Apr 9, 2022
@BobDotCom BobDotCom enabled auto-merge April 9, 2022 21:06
EmreTech
EmreTech approved these changes Apr 9, 2022
View reviewed changes
Copy link
Contributor

@EmreTech EmreTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job Bob person coder

@BobDotCom BobDotCom merged commit 940049f into master Apr 9, 2022
v2.0 automation moved this from In progress to Done Apr 9, 2022
@Dorukyum Dorukyum deleted the uniontype_fix branch April 9, 2022 21:08
@Lulalaby
Copy link
Member

Lulalaby commented Apr 9, 2022

@krittick do your thing

@EmreTech EmreTech mentioned this pull request Apr 9, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@EmreTech EmreTech EmreTech approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@krittick krittick Awaiting requested review from krittick

Assignees

@BobDotCom BobDotCom

Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: No status
v2.0
  
Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BobDotCom @Lulalaby @EmreTech @Dorukyum