Add Page
class to ext.pages
to allow for greater flexibility with page contents
#1123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new class,
Page
toext.pages
, which allows users to specify both thecontent
andembeds
attributes. This allows the paginator to display pages with bothcontent
andembeds
, where previously it only allowed one or the other on each page.Existing usage of passing lists of strings or embeds still works as it did before.
This is being added as part of 2.0 to allow for a much easier guide to be written for end users rather than trying to have them understand the nuances of passing a list of embeds, list of list of embeds, or list of strings. Now they can just define their
Page
objects and pass a list of those.Checklist
type: ignore
comments were used, a comment is also left explaining why