Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Page class to ext.pages to allow for greater flexibility with page contents #1123

Merged
merged 10 commits into from Mar 6, 2022
Merged

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Mar 6, 2022

Summary

This adds a new class, Page to ext.pages, which allows users to specify both the content and embeds attributes. This allows the paginator to display pages with both content and embeds, where previously it only allowed one or the other on each page.

Existing usage of passing lists of strings or embeds still works as it did before.

This is being added as part of 2.0 to allow for a much easier guide to be written for end users rather than trying to have them understand the nuances of passing a list of embeds, list of list of embeds, or list of strings. Now they can just define their Page objects and pass a list of those.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added priority: high High Priority bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. Merge with squash ext.pages Relating to ext.pages labels Mar 6, 2022
@krittick krittick added this to the v2.0 milestone Mar 6, 2022
@krittick krittick added this to In progress in v2.0 via automation Mar 6, 2022
@krittick krittick self-assigned this Mar 6, 2022
@krittick krittick merged commit 24f05ed into Pycord-Development:master Mar 6, 2022
v2.0 automation moved this from In progress to Done Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. ext.pages Relating to ext.pages priority: high High Priority
Projects
No open projects
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant