Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure deployment to explicitly build from the sdist #375

Open
N-Wouda opened this issue Sep 2, 2023 · 0 comments
Open

Configure deployment to explicitly build from the sdist #375

N-Wouda opened this issue Sep 2, 2023 · 0 comments
Assignees
@N-Wouda
Labels
maintenance A maintenance chore

Comments

@N-Wouda
Copy link
Member

N-Wouda commented Sep 2, 2023

We don't currently do this, which means we cannot be certain the sdist indeed provides a full build. That's bitten us before - e.g. #374, and I think Leon and I talked about this once as well on Slack.

It should be possible to configure CIBW in the CD workflow to only build from the sdist, not from the repository. That'll take care of this: the deployment errors out if the sdist is missing files.
@N-Wouda N-Wouda added the maintenance A maintenance chore label Sep 2, 2023
@N-Wouda N-Wouda self-assigned this Sep 2, 2023
@N-Wouda N-Wouda mentioned this issue Jan 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@N-Wouda N-Wouda

Labels
maintenance A maintenance chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@N-Wouda