Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Explained Variance Metric + metric fix #4013

Merged
merged 5 commits into from Oct 9, 2020
Merged

Implement Explained Variance Metric + metric fix #4013

merged 5 commits into from Oct 9, 2020

Conversation

teddykoker
Copy link
Contributor

Implement Explained Variance Metric + quick add_state fix

@pep8speaks
Copy link

pep8speaks commented Oct 8, 2020 •
edited

Hello @teddykoker! Thanks for updating this PR.

Line 101:13: W503 line break before binary operator
Line 102:13: W503 line break before binary operator

Comment last updated at 2020-10-09 00:42:09 UTC

@mergify mergify bot requested a review from a team October 8, 2020 23:42
@mergify mergify bot requested a review from a team October 8, 2020 23:52
@ananyahjha93
Copy link
Contributor

@teddykoker test_add_state fails. Can you take a look?

@williamFalcon williamFalcon merged commit b961e12 into master Oct 9, 2020
@Borda Borda added feature Is an improvement or enhancement Metrics labels Oct 9, 2020
@Borda Borda added this to the 1.0 milestone Oct 9, 2020
@Borda Borda deleted the metrics/regression branch October 9, 2020 06:58
@Borda Borda added this to in Progress in Metrics package via automation Nov 8, 2020
@Borda Borda moved this from in Progress to Done in Metrics package Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananyahjha93 ananyahjha93 ananyahjha93 approved these changes

Assignees
No one assigned
Labels
feature Is an improvement or enhancement
Projects
No open projects
Metrics package
  
Done
Milestone
pl:1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@teddykoker @pep8speaks @ananyahjha93 @williamFalcon @Borda